Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alert about localhost when trigger is running inside container #3124

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix: alert about localhost when trigger is running inside container #3124

merged 2 commits into from
Sep 8, 2023

Conversation

mathnogueira
Copy link
Contributor

This PR fixes a behavior removed in #3120

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar
Copy link
Contributor

xoscar commented Sep 6, 2023

@mathnogueira we finally fixed the cypress issue, seems that it was a cache problem, feel free to rebase and or merge this if you need to

@mathnogueira mathnogueira merged commit 4e0515c into main Sep 8, 2023
@mathnogueira mathnogueira deleted the fix/trigger-inside-container branch September 8, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathnogueira @xoscar @danielbdias